Sync CRDTs with lexbox during crdt merge #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# Unit Tests75 tests 75 ✅ 5s ⏱️ Results for commit 5799ad6. ♻️ This comment has been updated with latest results. |
myieye
previously approved these changes
Nov 5, 2024
# Conflicts: # backend/FwHeadless/SendReceiveHelpers.cs # backend/FwHeadless/appsettings.Development.json # backend/FwHeadless/appsettings.json # backend/FwLite/LcmCrdt/LcmCrdtKernel.cs
myieye
previously approved these changes
Nov 7, 2024
rmunn
requested changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously crdt changes would only stay on the fw-headless server, now they are synced to lexbox. We're calling the API as that allows the clients to be notified directly, if we inserted directly into the db then clients would not be notified.
I also tweaked the sync api so it closes the fwdata project once it's done
closes #1172